Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Upgrades #565

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Package Upgrades #565

wants to merge 9 commits into from

Conversation

travis-r6s
Copy link
Member

This upgrades all dependencies in package.json, and fixes two issues that came up as a result:

  • yaml.safeLoad has been replaced by yaml.load
  • Algolia SSR mixins have been renamed

@hjvedvik
Copy link
Member

This looks very good, @thetre97. Thanks! One thing I noticed in the build log is that webpack-node-externals has changed the whitelistoption to allowlist. Would be nice if you can change it here :)

@travis-r6s
Copy link
Member Author

Ah, good catch! Done

@travis-r6s
Copy link
Member Author

I'll take a look at the next build error now as well 😏

@travis-r6s
Copy link
Member Author

@hjvedvik I kept getting this error Could not generate HTML for "__plugins_id": TypeError: Cannot read property 'propsData' of undefined unless I removed the serverPrefetch function. It seems to work fine without it, but was it needed for something previously, presumably prefetching search results at build time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjvedvik hjvedvik Awaiting requested review from hjvedvik

At least 1 approving review is required to merge this pull request.

Assignees

@hjvedvik hjvedvik

@travis-r6s travis-r6s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travis-r6s @hjvedvik